masahi commented on a change in pull request #10578:
URL: https://github.com/apache/tvm/pull/10578#discussion_r826579381
##########
File path: src/meta_schedule/integration.cc
##########
@@ -121,14 +113,18 @@ ApplyHistoryBest::ApplyHistoryBest(Database database) {
data_ = n;
}
-Optional<ObjectRef> ApplyHistoryBestNode::Query(runtime::String task_name,
IRModule mod,
- Target target,
- Optional<Array<IRModule>>
dispatched) {
+IRModule ApplyHistoryBestNode::Query(runtime::String task_name, IRModule mod,
Target target,
+ Optional<Array<IRModule>> dispatched) {
ICHECK(dispatched.defined());
ICHECK_EQ(dispatched.value().size(), 1);
ICHECK(HasOnlyOneFunction<relay::Function>(mod)) << mod;
IRModule prim_mod = dispatched.value()[0];
ICHECK(HasOnlyOneFunction<tir::PrimFunc>(prim_mod)) << prim_mod;
+ // TODO(masahi): parse_mod below replaces the orginal function key with
"main".
+ // This is necessary because some scheduling primitives requires the
PrimFunc key be "main".
Review comment:
also cc @zxybazh. I'd love to remove the need for `Parse._mod` thing
https://github.com/apache/tvm/blob/1271e6cc34eda7be8ce7502c206b1dcef11ab4f1/python/tvm/meta_schedule/tune.py#L214-L219
Is there another reason we need this, other than `get_block` assuming the
func name be `main` by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
