areusch commented on a change in pull request #10525:
URL: https://github.com/apache/tvm/pull/10525#discussion_r828522403
##########
File path: Jenkinsfile
##########
@@ -214,6 +226,100 @@ stage('Sanity Check') {
}
}
+def build_image(image_name) {
+ hash = sh(
+ returnStdout: true,
+ script: 'git log -1 --format=\'%h\''
+ ).trim()
+ hash = "${env.BRANCH_NAME}-${hash}"
+ sh(
+ script: "${docker_build} ${image_name} --spec ${image_name}:${hash}",
+ label: 'Building docker image'
+ )
+ sh "echo NYI: Uploading docker image to registry..."
Review comment:
i think we should docker rmi after this step, and maybe do that in this
PR so we don't cause nodes to run out of disk
##########
File path: Jenkinsfile
##########
@@ -214,6 +226,100 @@ stage('Sanity Check') {
}
}
+def build_image(image_name) {
+ hash = sh(
+ returnStdout: true,
+ script: 'git log -1 --format=\'%h\''
+ ).trim()
+ hash = "${env.BRANCH_NAME}-${hash}"
+ sh(
+ script: "${docker_build} ${image_name} --spec ${image_name}:${hash}",
+ label: 'Building docker image'
+ )
+ sh "echo NYI: Uploading docker image to registry..."
+}
+
+if (rebuild_docker_images) {
+ stage('Docker') {
+ // TODO in a follow up PR: Upload to ECR, find tag and use in
+ // subsequent builds
+ parallel 'ci-lint': {
Review comment:
do we have to do all of them?
##########
File path: Jenkinsfile
##########
@@ -214,6 +226,100 @@ stage('Sanity Check') {
}
}
+def build_image(image_name) {
+ hash = sh(
+ returnStdout: true,
+ script: 'git log -1 --format=\'%h\''
+ ).trim()
+ hash = "${env.BRANCH_NAME}-${hash}"
+ sh(
+ script: "${docker_build} ${image_name} --spec ${image_name}:${hash}",
+ label: 'Building docker image'
+ )
+ sh "echo NYI: Uploading docker image to registry..."
+}
+
+if (rebuild_docker_images) {
+ stage('Docker') {
Review comment:
maybe Docker Image Build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
