AndrewZhaoLuo commented on pull request #10663: URL: https://github.com/apache/tvm/pull/10663#issuecomment-1071463950
Hmm, so the unordered map doesn't have an ordering so all it needs is some way of determining equality of elements. An alternative would be `std::map` which does have a notion of ordering (and you can define a comparator). However, it's performance characteristics are different (usually self-balancing binary tree so O(log n) lookup instead of O(~1)). In general though yeah, we need to be on the lookout for iterating over unordered collections cause it will be non-determinstic. I'll try refactoring this sometime later, though need to read more about performance (it's already kind of slow when processing a statement with 100 common subexpressions). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
