PhilippvK commented on issue #10270: URL: https://github.com/apache/tvm/issues/10270#issuecomment-1073536501
@gromero My bad. Sorry for messing this up. > Since you've done all the analysis and also reported it, are you interested in sending a PR to fix it? I like the solution of using a simple dict map and I think such a map could be a global as CMAKE_BOOL_MAP and defined right above class Handle(), for instance so in the future other options can take advantage of it too I would be happy to create a PR for this. However I think that the main issue is not fully solved by your suggested solution as it would only resolve boolean options correctly while options of type `int` would still be accessed as string. So we should either actually make use of the type hints in `server.ProjectOption` to implicitly convert those options to the chosen type or alternatively mention somewhere, that the user has to parse/cast them manually. What do you think about this? Another short question: What do you mean with `class Handle()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
