masahi removed a comment on pull request #10691: URL: https://github.com/apache/tvm/pull/10691#issuecomment-1074541044
I realized that this is not specific to meta scheduler (the one I tested), but the same error could happen for auto scheduler as well since it also relies on the structure of the input relay subgraph for a workload lookup. All tests have passed without `DynamicToStatic` in `relay.build(...)`. As the diff shows, this investigation uncovered a few cases where frontends are introducing dynamic ops carelessly, or some TF frontend tests are using graph runtime for a model containing dynamic inputs (but just happen to be working thanks to `DynamicToStatic` since dynamic-inputs are bound to a constant tensor before `relay.build(...)`, and after the frontend conversion. This is a very strange usage and they should be using VM in the first place). So I believe it is better to remove `DynamicToStatic` in `relay.build(...)` to prevent those sloppy coding in the frontends. But if people instead prefer running `DynamicToStatic` in the VM path as well, it's fine for me to do that. But I'd like to be convinced that such use of `DynamicToStatic` really solves non-trivial problems. Let me know your thought @mbrookhart @tkonolige @comaniac @zxybazh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
