Lunderberg commented on a change in pull request #10712:
URL: https://github.com/apache/tvm/pull/10712#discussion_r833391101
##########
File path: python/tvm/runtime/ndarray.py
##########
@@ -249,6 +249,28 @@ def copyto(self, target):
return self._copyto(res)
raise ValueError("Unsupported target type %s" % str(type(target)))
+ def create_view(self, shape):
Review comment:
Agreed, and updated the name to `_create_view` and the docstring to
include a warning.
In the future, I want to make it easier to interact with the different
shapes (logical shape, transformed shape, physical shape), but am still working
through the different interaction points needed. With respect to a safe API
here, I *think* that would either be `tvm.nd.empty` allow the tensor shape and
the shape of the backing allocation to be independently specified, but I
haven't finished fleshing out that design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
