junrushao1994 commented on a change in pull request #10538:
URL: https://github.com/apache/tvm/pull/10538#discussion_r833601447
##########
File path: python/tvm/tir/schedule/schedule.py
##########
@@ -71,6 +73,13 @@ def __init__(self) -> None:
}
+class BufferType(enum.IntEnum):
+ """Type of buffer in access regions of a block"""
+
+ READ = 0
+ WRITE = 1
+
Review comment:
@vinx13 Sorry I'm late and missed the code review. On this particular
change, I'm 100% in favor of having enum type on C++ side; However, it could be
more to "just use string" on the python side, i.e. use "read" and "write" to
indicate BufferType. If you agree with my opinion, would you mind sending a
quick patch? Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
