Lunderberg commented on a change in pull request #10710:
URL: https://github.com/apache/tvm/pull/10710#discussion_r833610731
##########
File path: src/target/llvm/codegen_hexagon.cc
##########
@@ -69,6 +69,9 @@ class CodeGenHexagon final : public CodeGenLLVM {
llvm::Module* GetModulePtr() const { return module_.get(); }
protected:
+ void CreatePrintf(const std::string& format,
+ const llvm::ArrayRef<llvm::Value*>& format_args) final;
Review comment:
Ah, whoops. Thank you for the catch, and sorry on that. I had been
thinking it was a drop-in replacement for `std::vector` that owned its
contents. I'm fine fixing it either here or in a different PR; either way
works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
