sfvaroglu commented on a change in pull request #10718:
URL: https://github.com/apache/tvm/pull/10718#discussion_r833750961



##########
File path: src/relay/qnn/op/op_common.h
##########
@@ -286,7 +346,10 @@ static inline bool QnnBroadcastRel(const Array<Type>& 
types, int num_inputs, con
       .add_argument("rhs_zero_point", "Tensor", "The zero_point of the rhs 
tensor.")               \
       .add_argument("output_scale", "Tensor", "The scale of the output 
tensor.")                   \
       .add_argument("output_zero_point", "Tensor", "The zero_point of the 
output tensor.")         \
+      .add_argument("lhs_axis", "Tensor", "The channel quantization of the lhs 
tensor.")           \
+      .add_argument("rhs_axis", "Tensor", "The channel quantization of the rhs 
tensor.")           \
       .add_type_rel("QnnBroadcast", QnnBroadcastRel)                           
                    \
+      .set_attr<TOpPattern>("TOpPattern", kOpaque)                             
                    \

Review comment:
       Yes. At some point I was getting an error since this pattern was 
missing, but now it's gone (tried a few different things in this branch). So, 
I'm gonna remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to