Lunderberg commented on pull request #10765: URL: https://github.com/apache/tvm/pull/10765#issuecomment-1078073492
I like this! I do have have some worry that it could give false positives when measuring a very fast function using a low-resolution clock. The default timer uses `std::chrono::high_resolution_clock`, but it could be overridden. Can we add a condition to the check, such that it only triggers if more than ~10 ms has passed on the host? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
