cconvey commented on a change in pull request #10604:
URL: https://github.com/apache/tvm/pull/10604#discussion_r836554743



##########
File path: tests/python/contrib/test_hexagon/test_launcher.py
##########
@@ -40,6 +42,251 @@
 # triggering TIME_WAIT state on the server socket. This prevents another
 # server to bind to the same port until the wait time elapses.
 
+@requires_hexagon_toolchain
+def test_add_hvx(android_serial_number, tvm_tracker_host, tvm_tracker_port, 
adb_server_socket):
+    """
+    Starting with an elementwise-add computation, try various schedules / 
optimizations to
+    see the impact they have on performance.
+
+    The main motivation for this test is to explore the relationship between 
these
+    schedules / optimizations vs. how effectively the primfunc uses the 
Hexagon's
+    HVX units.
+    """
+
+    host_output_dir = tempfile.mkdtemp()
+
+    print("-"*80)
+    print("OUTPUT DIRECTORY: {}".format(host_output_dir))
+    print("-"*80)
+    print()
+
+    class benchmark_results_collection:

Review comment:
       It's a cool idea.  Right now AFAIK this is the only Hexagon benchmarking 
script in the neighborhood.  How about I add a "this could be turned into a 
fixture" comment to the code, and we do that refactoring if/when there's 
another script that needs it?  Otherwise I fear this would be premature 
generalization.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to