junrushao1994 commented on pull request #10810: URL: https://github.com/apache/tvm/pull/10810#issuecomment-1081511428
> Yeah, I was aware of this issue. I didn't do anything at that time since I was not sure if the order of numbering matters at all, as long as they are unique. Even with this change, I don't know if we can guarantee that the order obtained by PostOrderVisit -> std::reverse is guaranteed to be the same as the one used by TE compiler. @masahi Yep exactly, that's my doubt too! For now it is not a problem in terms of correctness, because the names themselves are fine as long as they are unique. The only occasion that I spotted this issue is when doing per-layer performance comparison with Ansor, and the names of each layer becomes a bit...different :-) > I really like the simplicity of this change, compared to how weights are extracted in the auto scheduler... (te_compiler_update_weights thing) That's completely based on your work! Literally standing on the shoulder of your super cool refactoring! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
