ekalda commented on a change in pull request #10510:
URL: https://github.com/apache/tvm/pull/10510#discussion_r838511632
##########
File path: python/tvm/contrib/ethosu/cascader/device_config.py
##########
@@ -492,29 +492,31 @@ def get_elementwise_block_config(
banks_available -= 2
# Split the block in half until it fits into SHRAM
+ max_height, max_width, max_depth = self._max_block_shape.as_list()[1:]
if output_layout == "NHCWB16":
split_order = (a for a in [1, 3, 2])
output_block = [
output_shape[0],
- min(output_shape[1], self._max_block_shape.height),
- min(output_shape[2] * output_shape[4],
self._max_block_shape.depth),
- min(output_shape[3], self._max_block_shape.width),
+ _round_up(min(output_shape[1], max_height),
self._micro_block.height),
+ min(output_shape[2] * output_shape[4], max_width),
Review comment:
Probably shouldn't take min with `max_width`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
