masahi commented on a change in pull request #10366:
URL: https://github.com/apache/tvm/pull/10366#discussion_r841030902
##########
File path: tests/python/unittest/test_meta_schedule_tune_tir.py
##########
@@ -98,14 +97,14 @@ def test_tune_matmul_cuda_tensor_core():
target = Target("nvidia/geforce-rtx-3070")
config = ReplayTraceConfig(
num_trials_per_iter=32,
- num_trials_total=320,
+ max_trials_per_task=320,
Review comment:
> We updated the usage of this API in the following files:
python/tvm/meta_schedule/testing/tune_te_meta_schedule.py
python/tvm/meta_schedule/testing/tune_relay_meta_schedule.py
tests/python/unittest/test_meta_schedule_measure_callback.py
tests/python/unittest/test_meta_schedule_search_strategy.py
tests/python/unittest/test_meta_schedule_task_scheduler.py
tests/python/unittest/test_meta_schedule_tune_relay.py
tests/python/unittest/test_meta_schedule_tune_te.py
tests/python/unittest/test_meta_schedule_tune_tir.py
I don't see any updated usage... can you double check? Actually
`ReplayTraceConfig` seems to be used only in three integration test files.
But yeah, I didn't notice that `max_trials_global` is used outside of
`ReplayTraceConfig` class as `config.max_trials_global`, so I thought its value
doesn't matter. I'll revisit this issue after seeing your fix to the
integration tests.
I understand the risk of being an early user, but I'd like to see at least
reasonable documentation of the API at all times, regardless of being stable /
unstable. Especially when you introduce a breaking change. In this particular
case, the new attribute `max_trials_global` is not documented and there is no
example of how to use this value, as far as I can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
