tkonolige commented on code in PR #10765: URL: https://github.com/apache/tvm/pull/10765#discussion_r841944963
########## src/runtime/rpc/rpc_module.cc: ########## @@ -21,6 +21,10 @@ * \file rpc_module.cc * \brief RPC runtime module. */ +#if defined(__hexagon__) +#define TVM_LOG_CUSTOMIZE 1 +#endif Review Comment: `TVM_LOG_CUTOMIZE` needs to be defined for every file across the codebase. This should be set from cmake instead of set inline like this. It should already be set here: https://github.com/apache/tvm/blob/main/cmake/modules/Hexagon.cmake#L158. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
