csullivan commented on code in PR #10765:
URL: https://github.com/apache/tvm/pull/10765#discussion_r842020005
##########
src/runtime/rpc/rpc_module.cc:
##########
@@ -21,6 +21,10 @@
* \file rpc_module.cc
* \brief RPC runtime module.
*/
+#if defined(__hexagon__)
+#define TVM_LOG_CUSTOMIZE 1
+#endif
Review Comment:
I'm in favor of not proliferating these outside of the hexagon runtime
sources,
> #if defined(__hexagon__)
#define TVM_LOG_CUSTOMIZE 1
#endif
Ideally we update the hexagon runtime sources to not require this anymore.
But to decouple the problem with the comments above you made about Hexagon
@cconvey, can we refactor the Hexagon runtime translation in a later PR, and
accept that for now the Hexagon runtime won't receive this error message (and
any other LOGged message) outside of the hexagon runtime translation units?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
