cconvey commented on code in PR #10765: URL: https://github.com/apache/tvm/pull/10765#discussion_r842069755
########## src/runtime/rpc/rpc_module.cc: ########## @@ -21,6 +21,10 @@ * \file rpc_module.cc * \brief RPC runtime module. */ +#if defined(__hexagon__) +#define TVM_LOG_CUSTOMIZE 1 +#endif Review Comment: IIRC the only practical consequence adding `#define TVM_LOG_CUSTOMIZE 1` to this file is that the output of `LOG(FATAL)` contains `__FILE__` and `__LINE__`. Based on a side conversation with @tkonolige , I'm thinking to simply remove the `#if defined(hexagon) ... #endif` chunk from the PR. That ducks the cmake issue, without diminishing the PR's main objective. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
