cconvey commented on PR #10891: URL: https://github.com/apache/tvm/pull/10891#issuecomment-1087942616
> > Now when `get_hexagon_sdk_property` can't obtain a valid path for `QAIC_EXE`, some (all?) callers need to check for that condition. > > All these checks do is display a warning. In case of a missing qaic, the warning is already shown in the property lookup itself. Right. An earlier version of this PR would cause `cmake` to fail if the qaic executable couldn't be found. The current version of this PR would only issue a warning during `cmake` execution, leaving the hard failure until the `make` invocation. I've been assuming that when possible, we want to trap errors during `cmake` execution rather than waiting until `make`, `ninja`, etc. attempt to build those targets. I'm not aware of TVM having a guideline about this, so if the other reviewers / committers are okay with it, that's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
