masahi commented on code in PR #10925: URL: https://github.com/apache/tvm/pull/10925#discussion_r844576160
########## python/tvm/tir/tensor_intrin/arm_cpu.py: ########## @@ -0,0 +1,151 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# pylint: disable=invalid-name +"""Intrinsics for x86 tensorization.""" +from .. import TensorIntrin +from tvm.script import tir as T + + +# TODO(masahi): Parametrize the TVMScript description of dot product by +# shape and dtype, and share the common description with x86. Review Comment: cc @junrushao1994 @yelite, this is one of the common needs for meta programming support in TVMScript. I think shape parameterization is possible via `specialize`, but not sure if I can use that with `T.Buffer` syntax sugar. A similar need arises for tensorcore (different mma shape x data type) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
