junrushao1994 commented on code in PR #10937:
URL: https://github.com/apache/tvm/pull/10937#discussion_r846667727
##########
src/meta_schedule/task_scheduler/task_scheduler.cc:
##########
@@ -127,7 +128,20 @@ void TaskSchedulerNode::Tune() {
ICHECK(!task->is_terminated);
ICHECK(!task->runner_futures.defined());
SearchStrategy strategy = task->search_strategy.value();
- if ((task->measure_candidates =
strategy->GenerateMeasureCandidates()).defined()) {
+ Optional<Array<MeasureCandidate>> candidates =
strategy->GenerateMeasureCandidates();
+ if (candidates.defined()) {
+ // Filter out invalid candidates.
+ // An invalid candidate can arise due to a schedule application failure
(e.g. tensorize).
+ Array<MeasureCandidate> valid_candidates;
+ for (MeasureCandidate candidate : candidates.value()) {
+ if (candidate.defined()) {
+ valid_candidates.push_back(candidate);
+ }
+ }
+
+ if (valid_candidates.size() == 0) continue;
Review Comment:
On the system design, we assume that MeasureCandidates are all valid ,
otherwise it's not meaningful to send invalid ones to measure.
In terms of implementation: In `ReplayTrace`, there is an infinite loop
https://github.com/apache/tvm/blob/main/src/meta_schedule/search_strategy/replay_trace.cc#L134-L142
until it finds a valid schedule. The same applies to `EvolutionarySearch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
