leandron commented on code in PR #10222: URL: https://github.com/apache/tvm/pull/10222#discussion_r847162573
########## docker/install/ubuntu_install_python.sh: ########## @@ -20,21 +20,17 @@ set -e set -u set -o pipefail -# install python and pip, don't modify this, modify install_python_package.sh -apt-get update -apt-get install -y python-dev - -# python 3.6 +# python 3.7 apt-get install -y software-properties-common add-apt-repository -y ppa:deadsnakes/ppa apt-get update -apt-get install -y python-pip python-dev python3.6 python3.6-dev +apt-get install -y python3.7 python3.7-dev -rm -f /usr/bin/python3 && ln -s /usr/bin/python3.6 /usr/bin/python3 +rm -f /usr/bin/python3 && ln -s /usr/bin/python3.7 /usr/bin/python3 # Install pip -cd /tmp && wget -q https://bootstrap.pypa.io/get-pip.py && python3.6 get-pip.py +cd /tmp && wget -q https://bootstrap.pypa.io/get-pip.py && python3.7 get-pip.py Review Comment: I suggest we change the Dockerfile to use `docker/install/ubuntu1804_install_python.sh` instead, rather than modifying this script, that might be used in other Dockerfiles. For reference: https://github.com/apache/tvm/blob/45f3d4a521ec476cd9960e3d2de4f66bde61bf23/docker/install/ubuntu1804_install_python.sh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
