kparzysz-quic commented on code in PR #10945:
URL: https://github.com/apache/tvm/pull/10945#discussion_r847523310
##########
python/tvm/contrib/hexagon/build.py:
##########
@@ -110,6 +110,7 @@ def __init__(self, rpc_info: dict, workspace: Union[str,
pathlib.Path] = None):
}
self._rpc_info.update(rpc_info)
self._workspace = self._create_workspace(workspace)
+ self._device_key = self.HEXAGON_REMOTE_DEVICE_KEY
Review Comment:
The idea is to get the PID of the process that starts the server. The
launcher itself may be created once ahead of time, and then we'd have the same
PID for every server. Since the base class only has an abstract method
`start_server`, the appending of the PID is done in the actual implementations.
I'm setting the member `_device_key`, here so that it exists in the object.
At the moment, the PID is only appended for the simulator. Do you think we
should do that for Android as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
