csullivan commented on code in PR #11016:
URL: https://github.com/apache/tvm/pull/11016#discussion_r850677956
##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -226,6 +226,7 @@ def alloc_buffer(
"""
special_stmt - Reads/Writes
"""
+
Review Comment:
```suggestion
```
##########
tests/python/contrib/test_hexagon/test_batch_matmul.py:
##########
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Should we move these tests to an `topi/` subdirectory? Thinking about how we
might want the directory structure. These are generic functionality tests, but
soon we'll have tests for some of the same operators which utilize more complex
scheduling. It would be nice to have these located in separate directories.
##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -337,6 +338,7 @@ def Assert(condition: Union[PrimExpr, builtins.bool],
message: str) -> PrimExpr:
"""
Scope handler - Loops
"""
+
Review Comment:
```suggestion
```
##########
tests/scripts/task_build_hexagon_api.sh:
##########
@@ -19,8 +19,18 @@
set -e
set -u
+use_cache=false
+if [ $# -ge 1 ] && [[ "$1" == "--use-cache" ]]; then
+ use_cache=true
+ shift 1
+fi
+
Review Comment:
Unrelated?
##########
src/runtime/hexagon/rpc/hexagon/rpc_server.cc:
##########
@@ -41,7 +41,7 @@ extern "C" {
#include "hexagon_rpc.h"
// TODO(mehrdadh): make this configurable.
-#define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 2 * 1024 * 1024
+#define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 5 * 1024 * 1024
Review Comment:
Looking at the TODO above, should we make this configurable now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
