kparzysz-quic commented on code in PR #11026:
URL: https://github.com/apache/tvm/pull/11026#discussion_r851633432
##########
tests/scripts/task_python_hexagon.sh:
##########
@@ -18,10 +18,34 @@
set -e
set -u
-set -x
-source tests/scripts/setup-pytest-env.sh
+device_serial="simulator"
+if [ $# -ge 1 ] && [[ "$1" = "--device" ]]; then
+ shift 1
+ device_serial="$1"
+ shift
+fi
+source tests/scripts/setup-pytest-env.sh
make cython3
+if [[ "${device_serial}" == "simulator" ]]; then
+ export TVM_TRACKER_PORT=9190
+ export TVM_TRACKER_HOST=0.0.0.0
+ env PYTHONPATH=python python3 -m tvm.exec.rpc_tracker --host
"${TVM_TRACKER_HOST}" --port "${TVM_TRACKER_PORT}" &
Review Comment:
This all runs in docker in CI, so from that perspective it doesn't matter if
the script leaves some processes behind.
We were hitting this issue in our downstream CI and we start the tracker in
a separate process group, then terminate all processes from the group with a
single `kill -TERM -${PGID}` command. I don't know what your approach to
running tracker from python would be, but keep in mind that python is not very
good at guaranteeing global cleanup: if the program exits in some abnormal way
(say, due to a syntax error), the execution will just stop and no "destructors"
will be run.
In any case, this issue was present even before this refactoring, so this is
not a regression. I'm ok with checking this in, and addressing the cleanup
issue in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
