manupa-arm commented on code in PR #10189:
URL: https://github.com/apache/tvm/pull/10189#discussion_r852743265
##########
include/tvm/ir/memory_pools.h:
##########
@@ -60,10 +59,12 @@ struct PoolInfoNode : public Object {
*/
bool is_internal = false;
+ /*! \brief The targets linked to the pool */
+ Array<Target> targets;
Review Comment:
@areusch RW/RO concept seemed redundant after introduction of the concept of
pools (we have discussed this here in the PR -- I'll post an update to the RFC
after these are settled).
Initially, it was proposed in the absense of the in-direction provided by
the memory pools (vs memories). Now, since we have that in-direction we dont
need to mix RW/RO in a single pool. Therefore it felt simpler just to use two
seperate pools for each and still place them in the same memory to get the same
effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
