tqchen commented on code in PR #11066: URL: https://github.com/apache/tvm/pull/11066#discussion_r854070352
########## python/tvm/analysis/__init__.py: ########## @@ -0,0 +1,296 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""High level analysis functions""" Review Comment: A new namespace is a main architectural choice as well as API choice itself that would benefit from broader [deliberation and discussions](https://tvm.apache.org/docs/contribute/code_review.html#deliberate-on-api-and-data-structures). Especially when we are not too sure about the choice of the name. So it might be helpful to get more inputs when introducing a new top-level namespace. I spend more time deliberating about the particular choices over night. The particular current module started with LLVM cpu target and is more like a standalone tooling that to be continuously improved and used. Our previous convention would start with such self-contained tooling in contrib, (e.g.`contrib/popen_pool`), indeed in those cases the contrib provides less info other than "collection of contributed tools", but they use less deliberations architectural-wise and can unblock the PR. And the current tooling matches the characteristics of other collections as well (depends on a few things and aimed to enable certain goals). In the meantime, if we want to think about possible ways to group things as the tooling matures, it would be great to open a discuss thread to also get some collective wisdoms from the community members. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
