PhilippvK commented on PR #10941:
URL: https://github.com/apache/tvm/pull/10941#issuecomment-1103944215

   @areusch 
   
   These are the two issues I ran into:
   
   1. As the frontend is not able to distinguish between real model inputs and 
parameters, I propagated all of the relay inputs with constant values. This way 
the model inputs are removed due to Constant Folding which makes the resulting 
model less complex. **Current Workaround:** Use `--input-shapes "x:[1,2,3]"` 
etc. (if available) to get the names of the actual  inputs and skip them when 
generating the parameter values.
   
   2. I wanted to experiment with some models which make use of 
`meta[relay.Constant]` for internal constant vectors. These relay models can 
only be parsed if the Relay model was exported via `ir_mod.astext()` (which 
uses `show_meta_data=True` by default). The `relay.txt` format used in the MLF 
archive is using `str(ir_mod)` does neither include the `#[metadata]` section 
nor the `#[version ...]` header. I added a checker to detect if one this 
information is missing.
   
   @areusch  Feel free to have another look at the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to