driazati commented on code in PR #11078:
URL: https://github.com/apache/tvm/pull/11078#discussion_r854449071
##########
python/setup.py:
##########
@@ -217,6 +226,8 @@ def get_package_data_files():
name="tvm",
version=__version__,
description="TVM: An End to End Tensor IR/DSL Stack for Deep Learning
Systems",
+ long_description=long_description_contents(),
+ long_description_content_type="text/markdown",
Review Comment:
It's not strictly related but can we round out some other areas for PyPi
while we're in here?
```suggestion
long_description_content_type="text/markdown",
url='https://tvm.apache.org/',
download_url='https://github.com/apache/tvm/tags',
author='Apache TVM',
license='Apache',
# See https://pypi.org/classifiers/
classifiers=[
"License :: OSI Approved :: Apache Software License",
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
"Intended Audience :: Education",
"Intended Audience :: Science/Research",
],
keywords='machine learning',
```
##########
python/setup.py:
##########
@@ -201,6 +201,15 @@ def get_package_data_files():
return ["relay/std/prelude.rly", "relay/std/core.rly"]
+def long_description_contents():
+ with open(
+ os.path.abspath(os.path.join(CURRENT_DIR, "..", "README.md")),
encoding="utf-8"
Review Comment:
nit: `pathlib` makes life easier
```suggestion
pathlib.Path(CURRENT_DIR).resolve().parent / "README.md",
encoding="utf-8"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
