ashutosh-arm commented on code in PR #10939:
URL: https://github.com/apache/tvm/pull/10939#discussion_r856121051


##########
tests/python/contrib/test_cmsisnn/test_conv2d.py:
##########
@@ -314,25 +312,29 @@ def test_conv2d_int8_tflite(ifm_shape, kernel_shape, 
strides, dilation, padding,
     interface_api = "c"
     use_unpacked_api = True
     test_runner = AOT_USMP_CORSTONE300_RUNNER
-
     dtype = "int8"
-    tflite_model, relay_mod, params = create_conv2d_tflite_relay_models(
-        ifm_shape, kernel_shape, strides, dilation, padding, activation, dtype
+
+    from tvm.relay.testing.tflite import TFLiteModel
+
+    tfl_model = TFLiteModel(dtype)
+    tfl_model.create_tflite_model(
+        "conv2d_single", ifm_shape, kernel_shape, strides, padding, dilation, 
activation
     )
+    relay_mod, relay_params = tfl_model.convert_to_relay()
 
-    cmsisnn_mod = cmsisnn.partition_for_cmsisnn(relay_mod, params)
+    cmsisnn_mod = cmsisnn.partition_for_cmsisnn(relay_mod, relay_params)
 
     # validate pattern matching
     assert_partitioned_function(relay_mod, cmsisnn_mod)
 
     # validate CMSIS-NN output against TFLite output
-    input_map, output_map, output_tolerance = 
generate_ref_data_tflite(tflite_model)

Review Comment:
   No, it should be removed in this commit itself. Why I backtracked I can't 
recall.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to