areusch commented on code in PR #10963:
URL: https://github.com/apache/tvm/pull/10963#discussion_r856382870


##########
python/tvm/autotvm/measure/measure_methods.py:
##########
@@ -496,7 +497,8 @@ def set_task(self, task):
 def _build_func_common(measure_input, runtime=None, check_gpu=None, 
build_option=None):
     """Common part for building a configuration"""
     target, task, config = measure_input
-    target, task.target_host = Target.check_and_update_host_consist(target, 
task.target_host)
+    assert not isinstance(target, (Map, dict)), "It's expected that 'target' 
is a string here."

Review Comment:
   @Mousius I spent some time looking to find the "highest-level" place we 
could put such an assert in the autotvm infrastructure. I believe it's 
[here](https://github.com/apache/tvm/blob/main/python/tvm/autotvm/tuner/tuner.py#L133).
 would that be better? We could just then and there assert that we always get 
an instance of `Target` (which should be true, looking at the log 
[decoder](https://github.com/apache/tvm/blob/main/python/tvm/autotvm/record.py#L157).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to