jacobbohlin commented on code in PR #10509:
URL: https://github.com/apache/tvm/pull/10509#discussion_r857737973
##########
python/tvm/contrib/ethosu/cascader/scheduler.py:
##########
@@ -169,13 +172,19 @@ def create_home_map(
return home_map
-def choose_proposal(proposals: List[Proposal], cascade_region: MemoryRegion):
+def choose_proposal(
+ proposals: List[Proposal], cascade_region: MemoryRegion,
select_proposal_idx: int
+):
"""Choose the best performing Proposal that doesn't overflow the cascade
region."""
- proposal_choice = proposals[0]
- for proposal in reversed(proposals):
- if proposal.memory_usage < cascade_region.size:
- proposal_choice = proposal
- break
+ if select_proposal_idx != -1:
+ # Manually select proposal based on index
+ proposal_choice = proposals[select_proposal_idx % len(proposals)]
Review Comment:
It's just to ensure that we always select a proposal. I can add a comment to
clarify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
