cconvey commented on PR #11116: URL: https://github.com/apache/tvm/pull/11116#issuecomment-1108938409
> With `-DCMAKE_MAKE_PROGRAM=make` this will cause all dependencies to be built serially (i.e. as in `make -j1`), even if you say `make -j8` for the hexagon_api as a whole... Thanks, I agree that it makes sense to keep the ability for parallel builds with Gnu Make. I'm now looking for ways to achieve that. One challenge is how two of the `ExternalProject_add` calls are structured: - https://github.com/apache/tvm/blob/d89234b47abdbb090f9f32e68dcff6fd6cd3d4a1/apps/hexagon_api/CMakeLists.txt#L57-L76 - https://github.com/apache/tvm/blob/d89234b47abdbb090f9f32e68dcff6fd6cd3d4a1/apps/hexagon_api/CMakeLists.txt#L96-L114 Specifically, they combine two details that make life more difficult, particularly for CMake version < 3.15: - a single `BUILD_COMMAND` explicitly builds _multiple_ targets in the external project, and - specifies `BUILD_ALWAYS=ON`. I hesitate to change this without knowing why it's currently done this way. Anyone know what motivates this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
