alanmacd commented on code in PR #11044:
URL: https://github.com/apache/tvm/pull/11044#discussion_r859117149


##########
src/target/source/source_module.cc:
##########
@@ -771,11 +771,41 @@ class MetadataSerializer : public AttrVisitor {
   std::vector<bool> is_defining_struct_;
 };
 
+namespace {
+runtime::Module CreateAotMetadataModule(runtime::metadata::Metadata 
aot_metadata) {
+  MetadataSerializer serializer;
+  serializer.CodegenMetadata(aot_metadata);
+  std::stringstream lookup_func;
+  lookup_func << "#ifdef __cplusplus\n"
+              << "extern \"C\"\n"
+              << "#endif\n";
+
+  lookup_func << "TVM_DLL int32_t " << 
::tvm::runtime::symbol::tvm_get_c_metadata

Review Comment:
   @areusch Addressed this issue with [latest 
commit](https://github.com/apache/tvm/pull/11044/commits/a7c07e40171df87557d6ba4a9bbf3b5b4a6bbf2c)
 as adding the module name was needed to avoid function name collisions when 
running certain CI tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to