mkatanbaf commented on code in PR #10967:
URL: https://github.com/apache/tvm/pull/10967#discussion_r861415661
##########
python/tvm/rpc/client.py:
##########
@@ -505,7 +508,7 @@ def connect(url, port, key="", session_timeout=0,
session_constructor_args=None)
client_via_proxy = rpc.connect(
proxy_server_url, proxy_server_port, proxy_server_key,
session_constructor_args=[
- "rpc.Connect", internal_url, internal_port, internal_key])
+ "rpc.Connect", internal_url, internal_port, internal_key,
enable_logging])
Review Comment:
Not sure if I understand your comment. This is not a function call, it's a
list of parameters that would later pass to rpc.Connect on the device. so, I
believe we cannot write down the param_name=value, it only has to be the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
