tqchen commented on PR #11066: URL: https://github.com/apache/tvm/pull/11066#issuecomment-1113238429
Thank you @tkonolige for the contribution and @csullivan @AndrewZhaoLuo for reviewing. As the current proposal now we introduced a new top-level namespace (`utils`). While I personally also would tend to agree with the namespace choice, as stated in an earlier comment, please open a discuss thread for posterity since this would be a case to get community involvement and awareness as new top-level is a main architectural choice. After a new namespace is introduced, it usually less common to have implementations directly sit in `__init__.py`, as a new namespace would entail further grows of tools of similar kind in the same namespace. As a result, it would be helpful to move the implementation to a separate file(or files, e.g. roofline.py or other better names) under the same namespace then import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
