echuraev commented on code in PR #11180:
URL: https://github.com/apache/tvm/pull/11180#discussion_r861824053
##########
src/runtime/opencl/opencl_common.h:
##########
@@ -229,6 +229,8 @@ class OpenCLWorkspace : public DeviceAPI {
cl_context context{nullptr};
// whether the workspace it initialized.
bool initialized_{false};
+ // whether the workspace is in profiling mode.
+ bool profiling{false};
Review Comment:
Just another idea for discuss. You can get the properties on the queue and
check if the profiling was enabled or not. In this case, it is not necessary to
introduce this variable.
Note: you can request properties by using
[clGetCommandQueueInfo](https://www.khronos.org/registry/OpenCL/sdk/1.1/docs/man/xhtml/clGetCommandQueueInfo.html)
Also, in case if you have several queues for different devices. Using global
variable won't be safe.
Probably in this case it will be better to introduce method
`isProfilingEnabled(device or queue)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
