leandron opened a new issue, #11186: URL: https://github.com/apache/tvm/issues/11186
Our current mechanisms used to add `data_files` to the setuptools configuration is only handling file names correctly. This is because when it was implemented, only files like `libtvm.so` were added. In recent implementations we added directories as libraries, which don't match with the `data_files` syntax, meaning that if we try to run `python setup.py install`, it will fail with "error: can't copy '../configs/': doesn't exist or not a regular file". The bug is symptomatic after my PR https://github.com/apache/tvm/pull/11063, but the problem was always there, meaning that if we had `USE_MICRO ON` set at build time, we would notice this long ago. I'm raising this bug because I couldn't find a quick solution to push as a PR, because data files are a bit fiddly in the way the handle directory structures to preserve them. One option would be unifying the use of the MANIFEST file used currently only for the wheel, but I see the current mechanism is implemented on purpose to differentiate wheel from local installation. @tqchen do you remember if we have any specific reason why we can't just use the MANIFEST file for all non-Conda installations? I tried it locally and it seems to work. This is the relevant snippet: https://github.com/apache/tvm/blob/6b45f8dc4ad0cfecf07dbd031b1e55fe4c9b02c5/python/setup.py#L167-L197 cc @driazati @tqchen @areusch @Mousius for visibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
