adstraw commented on PR #11145: URL: https://github.com/apache/tvm/pull/11145#issuecomment-1113631599
> Is there a reason that you put test files under `src/runtime/hexagon/tests/` instead of `tests/cpp/...`? Short answer: We need a separate directory from which to include runtime tests. Long answer ... All files in `tests/cpp/...` are recursively [globbed](https://github.com/apache/tvm/blob/c6578834bc34a8721844197df03e0cef83440adf/CMakeLists.txt#L634) and added to the `cpptest` executable. This forces all code tested by `cpptest` to have an x86 implementation. For runtime code, it may or may not be possible to have an x86 implementation. The `HexagonBuffer` class, for example, was able to have both a Hexagon (VTMC allocation via the SDK) and x86 (malloc) implementation and hence was testable using `cpptest` on x86. However, this added some complication to the build system which is removed in this PR along with the x86 implementation for `HexagonBuffer`. `HexagonBuffer` is now implemented and tested on Hexagon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
