junrushao1994 commented on code in PR #11157:
URL: https://github.com/apache/tvm/pull/11157#discussion_r862214712
##########
src/meta_schedule/schedule_rule/cross_thread_reduction.cc:
##########
@@ -32,12 +32,14 @@ class CrossThreadReductionNode : public ScheduleRuleNode {
Optional<Integer> opt_warp_size =
target->GetAttr<Integer>("thread_warp_size");
if (!opt_max_threads_per_block.defined()) {
- LOG(WARNING) << "Target does not have attribute
\"max_threads_per_block\", therefore the "
- "rule CrossThreadReduction will not be applied";
+ TVM_PY_LOG(WARNING, context->logging_func)
Review Comment:
I was thinking if it's better to make it a LOG(FATAL) instead, but it's do
that in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
