supersat commented on PR #11018: URL: https://github.com/apache/tvm/pull/11018#issuecomment-1114623056
After discussing with @csullivan, I've reverted the refactoring changes. Those changes relied on separate source files being built for separate targets, but PR #11090 introduces changes that build Hexagon sources for all targets, necessitating more #ifdefs. Eventually the build system should only build target-specific sources when building for that target. There's a lot of cruft already in TVM because this isn't the case (e.g., #ifdef WIN32 in hexagon_buffer.cc and others). However, fixing that is a non-trivial task, so we plan to leave that to a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
