AndrewZhaoLuo commented on code in PR #11171:
URL: https://github.com/apache/tvm/pull/11171#discussion_r863489787
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -5174,6 +5172,10 @@ def test_onnx_nodes(target, dev, onnx_test):
# roialign results to 4 decimal places
atol = 1e-4
+ if "to_BFLOAT16" in test_dir:
+ # casting to BFLOAT has a larger accuracy loss
+ atol = 1
Review Comment:
I think it's fine to set atol to 1. But would like a comment on why it's 1
and why this really isn't that big deal (e.g. it's just the mantissa being off
by 1 which is the minimum difference between any two floating point numbers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
