cconvey commented on code in PR #11189:
URL: https://github.com/apache/tvm/pull/11189#discussion_r864022510


##########
CMakeLists.txt:
##########
@@ -509,6 +510,103 @@ set(LIBINFO_FILE 
${CMAKE_CURRENT_LIST_DIR}/src/support/libinfo.cc)
 add_lib_info(${LIBINFO_FILE})
 list(REMOVE_ITEM COMPILER_SRCS ${LIBINFO_FILE})
 
+# Caches the build.
+# Note that ccache-3.x doesn't support nvcc well, so CUDA kernels may never 
hit the cache and still
+# need to be re-compiled every time. Using ccache 4.0+ can resolve this issue.
+#
+# NOTE: CMAKE_C[XX]_COMPILER_LAUNCHER only affects build targets that we add 
*later*.
+# So we want this logic to appear towards the top of thet this CMakeLists.txt 
file.
+if(USE_CCACHE) # True for AUTO, ON, /path/to/ccache
+
+  
#-------------------------------------------------------------------------------------------------
+  # Determine which requested policy.

Review Comment:
   Clearly written before my second cup of coffee.  Needs rewording.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to