csullivan commented on code in PR #11161:
URL: https://github.com/apache/tvm/pull/11161#discussion_r864261462


##########
src/runtime/opencl/opencl_common.h:
##########
@@ -345,6 +345,7 @@ struct BufferDescriptor {
      *         e.g. image2d[height=O, width=IHW]
      */
     kImage2DWeight,
+    kTexture2DNHWC,

Review Comment:
   I like that idea. Something like,
   
   > TODO(tvm-team): Uncouple use of storage scope and data layout by using the 
transform_layout schedule primitive to express the desired texture layout. This 
will require supporting Nd indices in BufferLoad and BufferStore in 
CodegenOpenCL, and ensuring Nd allocations for texture are correctly routed to 
the AllocateTexture packed function in the OpenCL DeviceAPI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to