mbs-octoml commented on code in PR #11173:
URL: https://github.com/apache/tvm/pull/11173#discussion_r865014235
##########
src/target/compilation_config.cc:
##########
@@ -39,6 +38,27 @@ void CompilationConfigNode::VisitAttrs(AttrVisitor* v) {
// NOTE: The virtual_device_cache_ is not accessible via FFI.
}
+Target CompilationConfigNode::FindPrimitiveTargetOrFail(DLDeviceType
device_type) const {
+ if (device_type < 0 && primitive_targets.size() == 1) {
+ // In the homogenous case don't be fussy with device types.
Review Comment:
I believe we still have code paths that use a default device type -1 on the
assumption there's no ambiguity. The transition to supporting heterogeneous
targets unfortunately did not fully push the change all the way through. I put
a VLOG in and will keep an eye on it, perhaps I already caught all those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
