kparzysz-quic commented on code in PR #11214:
URL: https://github.com/apache/tvm/pull/11214#discussion_r865392111
##########
apps/hexagon_launcher/launcher_hexagon.cc:
##########
@@ -64,7 +64,22 @@ AEEResult __QAIC_HEADER(launcher_rpc_load)(remote_handle64
handle, const char* m
}
tvm::runtime::Module module = load_module(module_path);
- tvm::runtime::Module executor = create_graph_executor(graph_json, module,
Model::device());
+ std::string module_type = module->type_key();
+ tvm::runtime::Module executor;
+ if (module_type == "AotExecutorFactory") {
+ executor = create_aot_executor(module, Model::external());
+ } else if (module_type == "library") {
+ // We're not expecting "GraphExecutorFactory" here.
Review Comment:
I've never tried saving it. I think we may need to do `export_library` for
that, which only works with target `llvm`. The original idea was to strip all
the "factories" and just save the executable code for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
