lhutton1 commented on code in PR #11091:
URL: https://github.com/apache/tvm/pull/11091#discussion_r866262461
##########
src/relay/backend/aot_executor_codegen.cc:
##########
@@ -215,11 +217,21 @@ class AOTOnDemandAllocator : public
transform::DeviceAwareExprVisitor {
* \return The corresponding token.
*/
StorageInfo GetStorage(const Expr& expr) {
+ Expr true_expr = expr;
+
+ // Don't get storage for let nodes.
+ while (const auto* let_node = true_expr.as<LetNode>()) {
Review Comment:
Me and @manupa-arm discussed this offline and it turns out we can just avoid
let's being used in `GetStorage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
