shukun-ziqiangxu commented on PR #10504: URL: https://github.com/apache/tvm/pull/10504#issuecomment-1120434256
> > BTW, "Co-authored-by: shukun.net" in my commit is our company's commit rule for open source library like TVM, because the shukun info in my account is not noticeable, and the user account is inconstant. TVM is our important optimization tool for DL models, we will keep making contributions to TVM. Thanks for your understanding. > > @shukun-ziqiangxu Hi. I just would like to clarify what's the idea you're trying to convey here before I merge this PR. > > Is this PR from a single author or from multiple authors? > > If it's from a single author (I'm assuming in that case that the author is you, XU) won't `Co-authored-by: Ziqiang XU <[email protected]>` work for your employer's purpose? > > I'm asking that because the format `Co-authored-by: shukun.net` is inappropriate. > > Finally, I could not follow why the email found in the commit header does not work as a evidence that you're contribution from Shukun if it reads (from `git log`): > > ``` > Author: Ziqiang XU <[email protected]> > Date: Thu Mar 3 01:34:52 2022 +0800 > <snip> > ``` > > If the PR is from multiple authors working for Shukun, then could you please list each of them in a separate `Co-authored-by:` per line entry providing their respective names and emails? @gromero Sorry for my late reply. I have come to realize that this commit header format is inappropriate. Thanks for your patience tips, I have already known how to do it better. In the future contributions, I will make my PRs in more appropriate way. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
