Lunderberg commented on PR #11313: URL: https://github.com/apache/tvm/pull/11313#issuecomment-1126408924
@mehrdadh I expect this to conflict with [these changes](https://github.com/apache/tvm/pull/11294/files#diff-cde5d8f752ab76b94a72445b106884ca096adb729312a8ed270a7e7c96d14aadR407-R410) in PR#11294. Between the two, your PR takes priority, as it is solving an immediate issue. If all goes well, I don't expect the conflict to be difficult to resolve, as the corresponding change after this refactor would be to replace `target_kind_hardware="hexagon"` with `run_time_check=lambda: "ANDROID_SERIAL_NUMBER" in os.environ` in the definition of `requires_hexagon`, and to replace `requires_hexagon_toolchain` with `requires_hexagon(support_required="compile-only")`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
