Mousius commented on code in PR #11273:
URL: https://github.com/apache/tvm/pull/11273#discussion_r873480796
##########
docker/install/ubuntu_install_cmsis.sh:
##########
@@ -35,15 +35,16 @@ fi
INSTALLATION_PATH=$1
shift
-CMSIS_VER="5.8.0"
-
# Create installation path directory
mkdir -p "${INSTALLATION_PATH}"
# Download and extract CMSIS
-cd "${HOME}"
-wget --quiet
"https://github.com/ARM-software/CMSIS_5/archive/${CMSIS_VER}.tar.gz";
-tar -xf "${CMSIS_VER}.tar.gz" -C "${INSTALLATION_PATH}" --strip-components=1
+CMSIS_SHA="977abe9849781a2e788b02282986480ff4e25ea6"
+CMSIS_URL="http://github.com/ARM-software/CMSIS_5/archive/${CMSIS_SHA}.tar.gz";
+DOWNLOAD_PATH="/tmp/${CMSIS_SHA}.tar.gz"
+
+wget ${CMSIS_URL} -O "${DOWNLOAD_PATH}"
Review Comment:
Can we check the file SHA to ensure it's the file we expected?
Similar to:
https://github.com/apache/tvm/blob/70cc2abf91b5718b013fb4042dfe441d1918fcad/docker/install/ubuntu_install_boost.sh#L28-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
