Lunderberg commented on code in PR #11294:
URL: https://github.com/apache/tvm/pull/11294#discussion_r873705022
##########
tests/python/contrib/test_hexagon/test_thread_pool.py:
##########
@@ -66,8 +66,8 @@ def benchmark_func(mod, name, args, hexagon_session):
return evaluator(a, b, c, n).mean
-@requires_hexagon_toolchain
-def test_speedup(hexagon_session, capsys):
[email protected]_hexagon
+def test_speedup(hexagon_session: Session, capsys):
if hexagon_session is None:
Review Comment:
Since `hexagon_session` will be non-null whenever `ANDROID_SERIAL_NUMBER` is
set, and `tvm.testing.requires_hexagon` requires that `ANDROID_SERIAL_NUMBER`
is set, should we also use this to remove the `if hexagon_session is None`
checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
